From: Junio C Hamano <junkio@cox.net>
Date: Tue, 6 Mar 2007 11:20:55 +0000 (-0800)
Subject: revision --boundary: fix uncounted case.
X-Git-Tag: v1.5.1-rc1~50^2~6
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=8839ac9442c9ded41bfa369a142fd2e659a44377;p=git.git

revision --boundary: fix uncounted case.

When the list is truly limited and get_revision_1() returned NULL,
the code incorrectly returned it without switching to boundary emiting
mode.  Silly.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/revision.c b/revision.c
index f48d7f788..3c2eb125e 100644
--- a/revision.c
+++ b/revision.c
@@ -1301,13 +1301,14 @@ struct commit *get_revision(struct rev_info *revs)
 	/*
 	 * Now pick up what they want to give us
 	 */
-	if (!(c = get_revision_1(revs)))
-		return NULL;
-	while (0 < revs->skip_count) {
-		revs->skip_count--;
-		c = get_revision_1(revs);
-		if (!c)
-			break;
+	c = get_revision_1(revs);
+	if (c) {
+		while (0 < revs->skip_count) {
+			revs->skip_count--;
+			c = get_revision_1(revs);
+			if (!c)
+				break;
+		}
 	}
 
 	/*
@@ -1317,7 +1318,6 @@ struct commit *get_revision(struct rev_info *revs)
 	case -1:
 		break;
 	case 0:
-		/* Although we grabbed it, it is not shown. */
 		c = NULL;
 		break;
 	default: