From: Phil Lawrence <prlawrence@gmail.com>
Date: Mon, 9 Mar 2009 22:09:49 +0000 (-0500)
Subject: Append ampersand to "Target" of lnk files created by do_cygwin_shortcut
X-Git-Tag: v1.6.3-rc4~1^2~14
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=880fa117f197a2c1f41fb16b09cd1e8d6050d6fc;p=git.git

Append ampersand to "Target" of lnk files created by do_cygwin_shortcut

The git-gui menu item "Repository | Create Desktop Icon" creates a
shortcut (.lnk file) on the Windows desktop.  The purpose of the
created shortcut is to make it easy for a user to launch git-gui
for a particular repo in the future.

A Windows user would expect to see git gui launch when they click
the shortcut; they would not expect (nor want) to see a cmd window
open and remain open in the background.

msysGit avoids opening a command window altogether when it's Git GUI
shortcut is used.  Ideally, git on cygwin would also have shortcuts
that simply open the GUI, but as a first step, this change allows
the shell window to politely disappear after starting git gui as a
background process.

Signed-off-by: Phil Lawrence <prlawrence@gmail.com>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---

diff --git a/lib/shortcut.tcl b/lib/shortcut.tcl
index 38c3151b0..2f20eb39c 100644
--- a/lib/shortcut.tcl
+++ b/lib/shortcut.tcl
@@ -54,7 +54,7 @@ proc do_cygwin_shortcut {} {
 					$argv0]
 				win32_create_lnk $fn [list \
 					$sh -c \
-					"CHERE_INVOKING=1 source /etc/profile;[sq $me]" \
+					"CHERE_INVOKING=1 source /etc/profile;[sq $me] &" \
 					] \
 					[file dirname [file normalize [gitdir]]]
 			} err]} {