From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Mon, 15 Sep 2008 16:23:24 +0000 (-0500)
Subject: t9700/test.pl: avoid bareword 'STDERR' in 3-argument open()
X-Git-Tag: v1.6.0.3~95
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=8409bb3708e1dd7c035617795c49e4ca7e17c56a;p=git.git

t9700/test.pl: avoid bareword 'STDERR' in 3-argument open()

Some versions of perl complain when 'STDERR' is used as the third argument
in the 3-argument form of open(). Convert to the 2-argument form which is
described for duping STDERR in my second edition camel book.

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
Tested-by: Tom G. Christensen <tgc@statsbiblioteket.dk> on RHEL 3, Perl 5.8.0
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/t/t9700/test.pl b/t/t9700/test.pl
index 4d2312548..b47c71989 100755
--- a/t/t9700/test.pl
+++ b/t/t9700/test.pl
@@ -38,7 +38,7 @@ is($r->get_color("color.test.slot1", "red"), $ansi_green, "get_color");
 # Failure cases for config:
 # Save and restore STDERR; we will probably extract this into a
 # "dies_ok" method and possibly move the STDERR handling to Git.pm.
-open our $tmpstderr, ">&", STDERR or die "cannot save STDERR"; close STDERR;
+open our $tmpstderr, ">&STDERR" or die "cannot save STDERR"; close STDERR;
 eval { $r->config("test.dupstring") };
 ok($@, "config: duplicate entry in scalar context fails");
 eval { $r->config_bool("test.boolother") };