From: Jeff King Date: Mon, 9 Jan 2012 22:55:42 +0000 (-0500) Subject: send-email: multiedit is a boolean config option X-Git-Tag: v1.7.9-rc1~3^2~4 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=829a1c616967176ccd859c18a6e8ca0dda77f75a;hp=5f4d133fca7eb3cb750f056a6fd0281ba06cd12f;p=git.git send-email: multiedit is a boolean config option The sendemail.multiedit variable is meant to be a boolean. However, it is not marked as such in the code, which means we store its value literally. Thus in the do_edit function, perl ends up coercing it to a boolean value according to perl rules, not git rules. This works for "0", but "false", "no", or "off" will erroneously be interpreted as true. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/git-send-email.perl b/git-send-email.perl index d491db92c..ef30c557c 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -210,6 +210,7 @@ my %config_bool_settings = ( "signedoffbycc" => [\$signed_off_by_cc, undef], "signedoffcc" => [\$signed_off_by_cc, undef], # Deprecated "validate" => [\$validate, 1], + "multiedit" => [\$multiedit, undef] ); my %config_settings = ( @@ -227,7 +228,6 @@ my %config_settings = ( "bcc" => \@bcclist, "suppresscc" => \@suppress_cc, "envelopesender" => \$envelope_sender, - "multiedit" => \$multiedit, "confirm" => \$confirm, "from" => \$sender, "assume8bitencoding" => \$auto_8bit_encoding,