From: Jochen Voss Date: Sat, 28 Jun 2008 16:04:24 +0000 (+0100) Subject: avoid off-by-one error in run_upload_archive X-Git-Tag: v1.5.6.2~14 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=74d817cf8cf68104564cf6c93c1361f66dad1901;p=git.git avoid off-by-one error in run_upload_archive Make sure that buf has enough space to store the trailing \0 of the command line argument, too. Signed-off-by: Jochen Voss Signed-off-by: Junio C Hamano --- diff --git a/builtin-upload-archive.c b/builtin-upload-archive.c index 48ae09e9b..371400d49 100644 --- a/builtin-upload-archive.c +++ b/builtin-upload-archive.c @@ -30,7 +30,7 @@ static int run_upload_archive(int argc, const char **argv, const char *prefix) if (argc != 2) usage(upload_archive_usage); - if (strlen(argv[1]) > sizeof(buf)) + if (strlen(argv[1]) + 1 > sizeof(buf)) die("insanely long repository name"); strcpy(buf, argv[1]); /* enter-repo smudges its argument */