From: Trent Piepho Date: Wed, 26 Nov 2008 02:55:00 +0000 (-0800) Subject: send-email: Fix Pine address book parsing X-Git-Tag: v1.6.1-rc1~23 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=73c427eb99a9bb8a3ade40809194405ddb1fd733;p=git.git send-email: Fix Pine address book parsing See: http://www.washington.edu/pine/tech-notes/low-level.html Entries with a fcc or comment field after the address weren't parsed correctly. Continuation lines, identified by leading spaces, were also not handled. Distribution lists which had ( ) around a list of addresses did not have the parenthesis removed. Signed-off-by: Trent Piepho Signed-off-by: Junio C Hamano --- diff --git a/git-send-email.perl b/git-send-email.perl index 94ca5c89a..007e2c6ee 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -345,10 +345,13 @@ my %parse_alias = ( # spaces delimit multiple addresses $aliases{$1} = [ split(/\s+/, $2) ]; }}}, - pine => sub { my $fh = shift; while (<$fh>) { - if (/^(\S+)\t.*\t(.*)$/) { + pine => sub { my $fh = shift; my $f='\t[^\t]*'; + for (my $x = ''; defined($x); $x = $_) { + chomp $x; + $x .= $1 while(defined($_ = <$fh>) && /^ +(.*)$/); + $x =~ /^(\S+)$f\t\(?([^\t]+?)\)?(:?$f){0,2}$/ or next; $aliases{$1} = [ split(/\s*,\s*/, $2) ]; - }}}, + }}, gnus => sub { my $fh = shift; while (<$fh>) { if (/\(define-mail-alias\s+"(\S+?)"\s+"(\S+?)"\)/) { $aliases{$1} = [ $2 ];