From: Alex Riesen Date: Wed, 28 Nov 2007 21:13:08 +0000 (+0100) Subject: Do not generate full commit log message if it is not going to be used X-Git-Tag: v1.5.4-rc0~78^2~6 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=7168624c3530d8c7ee32f930f8fb2ba302b9801f;p=git.git Do not generate full commit log message if it is not going to be used Like when it is already specified through -C, -F or -m to git-commit. Signed-off-by: Alex Riesen Signed-off-by: Junio C Hamano --- diff --git a/builtin-commit.c b/builtin-commit.c index a35881e20..1a9a25688 100644 --- a/builtin-commit.c +++ b/builtin-commit.c @@ -367,6 +367,28 @@ static int prepare_log_message(const char *index_file, const char *prefix) strbuf_release(&sb); + if (no_edit) { + struct rev_info rev; + unsigned char sha1[40]; + + fclose(fp); + + if (!active_nr && read_cache() < 0) + die("Cannot read index"); + + if (get_sha1("HEAD", sha1) != 0) + return !!active_nr; + + init_revisions(&rev, ""); + rev.abbrev = 0; + setup_revisions(0, NULL, &rev, "HEAD"); + DIFF_OPT_SET(&rev.diffopt, QUIET); + DIFF_OPT_SET(&rev.diffopt, EXIT_WITH_STATUS); + run_diff_index(&rev, 1 /* cached */); + + return !!DIFF_OPT_TST(&rev.diffopt, HAS_CHANGES); + } + if (in_merge && !no_edit) fprintf(fp, "#\n"