From: Paul Mackerras <paulus@samba.org>
Date: Wed, 29 Aug 2007 12:41:34 +0000 (+1000)
Subject: gitk: Fix bug causing undefined variable error when cherry-picking
X-Git-Tag: v1.5.4-rc0~318^2~1^2~20
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=6eaaccd12846c5957c3433c773ad60b8a4196045;p=git.git

gitk: Fix bug causing undefined variable error when cherry-picking

When "Show nearby tags" is turned off and the user did a cherry-pick,
we were trying to access variables relating to the descendent/ancestor
tag & head computations in addnewchild though they hadn't been set.
This makes sure we don't do that.  Reported by Johannes Sixt.

Signed-off-by: Paul Mackerras <paulus@samba.org>
---

diff --git a/gitk b/gitk
index 0125f17fc..22a631842 100755
--- a/gitk
+++ b/gitk
@@ -6648,8 +6648,9 @@ proc splitarc {p} {
 proc addnewchild {id p} {
     global allids allparents allchildren idtags nextarc nbmp
     global arcnos arcids arctags arcout arcend arcstart archeads growing
-    global seeds
+    global seeds allcommits
 
+    if {![info exists allcommits]} return
     lappend allids $id
     set allparents($id) [list $p]
     set allchildren($id) {}