From: Julian Phillips Date: Sat, 16 Jul 2011 18:23:51 +0000 (+0100) Subject: remote-curl: Add a format check to parsing of info/refs X-Git-Tag: v1.7.6.1~55 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=6e8e67f3071ecdc139f6a77f90afee50b5ec1664;p=git.git remote-curl: Add a format check to parsing of info/refs When parsing info/refs, no checks were applied that the file was in the requried format. Since the file is read from a remote webserver, this isn't guarenteed to be true. Add a check that the file at least only contains lines that consist of 40 characters followed by a tab and then the ref name. Signed-off-by: Julian Phillips Signed-off-by: Junio C Hamano --- diff --git a/remote-curl.c b/remote-curl.c index b5be25ce9..8ac502834 100644 --- a/remote-curl.c +++ b/remote-curl.c @@ -227,6 +227,8 @@ static struct ref *parse_info_refs(struct discovery *heads) if (data[i] == '\t') mid = &data[i]; if (data[i] == '\n') { + if (mid - start != 40) + die("%sinfo/refs not valid: is this a git repository?", url); data[i] = 0; ref_name = mid + 1; ref = xmalloc(sizeof(struct ref) +