From: pjrm <pjrm@users.sourceforge.net>
Date: Wed, 20 Jun 2007 22:12:10 +0000 (+0000)
Subject: Add fixme comment re testing for file existence inside g_return_if_fail.
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=6dda1569f72d2fedf3ea32f9cc29238fd35fe7aa;p=inkscape.git

Add fixme comment re testing for file existence inside g_return_if_fail.
---

diff --git a/src/xml/repr-io.cpp b/src/xml/repr-io.cpp
index c1d764a8b..8369fb803 100644
--- a/src/xml/repr-io.cpp
+++ b/src/xml/repr-io.cpp
@@ -244,6 +244,9 @@ sp_repr_read_file (const gchar * filename, const gchar *default_ns)
 
     g_return_val_if_fail (filename != NULL, NULL);
     g_return_val_if_fail (Inkscape::IO::file_test( filename, G_FILE_TEST_EXISTS ), NULL);
+    /* fixme: A file can disappear at any time, including between now and when we actually try to
+     * open it.  Get rid of the above test once we're sure that we correctly handle
+     * non-existence. */
 
     // TODO: bulia, please look over
     gsize bytesRead = 0;