From: Florian Forster <octo@collectd.org>
Date: Wed, 10 Sep 2014 14:54:26 +0000 (+0200)
Subject: src/common.c: Fix strstripnewline().
X-Git-Tag: collectd-5.3.2~35
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=6d9b6a8844e6ba3c9bb941809f12d3964997c015;p=collectd.git

src/common.c: Fix strstripnewline().

Because the length of the string was decremented too late, the function
would actually overwrite the trailing null byte instead of the newline.
---

diff --git a/src/common.c b/src/common.c
index 9c4e64f6..b771f62e 100644
--- a/src/common.c
+++ b/src/common.c
@@ -370,8 +370,8 @@ size_t strstripnewline (char *buffer)
 		if ((buffer[buffer_len - 1] != '\n')
 				&& (buffer[buffer_len - 1] != '\r'))
 			break;
-		buffer[buffer_len] = 0;
 		buffer_len--;
+		buffer[buffer_len] = 0;
 	}
 
 	return (buffer_len);