From: Eric W. Biederman <ebiederm@xmission.com>
Date: Mon, 12 Jun 2006 19:31:38 +0000 (-0600)
Subject: Fix git-format-patch -s
X-Git-Tag: v1.4.1-rc1~25^2
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=6c4cca1c72f98c84a21a2d1916a8e86be57d26e6;p=git.git

Fix git-format-patch -s

When git-format-patch was converted to a builtin an appropriate call
to setup_ident was missed and thus git-format-patch -s fails because
it doesn't look up anything in the password file.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/builtin-log.c b/builtin-log.c
index 6afa66ce0..9187fd337 100644
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -220,8 +220,11 @@ int cmd_format_patch(int argc, const char **argv, char **envp)
 		}
 		else if (!strcmp(argv[i], "--signoff") ||
 			 !strcmp(argv[i], "-s")) {
-			const char *committer = git_committer_info(1);
-			const char *endpos = strchr(committer, '>');
+			const char *committer;
+			const char *endpos;
+			setup_ident();
+			committer = git_committer_info(1);
+			endpos = strchr(committer, '>');
 			if (!endpos)
 				die("bogos committer info %s\n", committer);
 			add_signoff = xmalloc(endpos - committer + 2);