From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Wed, 14 Dec 2011 14:07:09 +0000 (+0100)
Subject: compat/setenv.c: error if name contains '='
X-Git-Tag: v1.7.8.2~10^2
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=6ac1b2a3b8bd970e9fc175c42927f00d4d465bbf;p=git.git

compat/setenv.c: error if name contains '='

According to POSIX, setenv should error out with EINVAL if it's
asked to set an environment variable whose name contains an equals
sign. Implement this detail in our compatibility-fallback.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/compat/setenv.c b/compat/setenv.c
index 89947b713..fc1439a64 100644
--- a/compat/setenv.c
+++ b/compat/setenv.c
@@ -6,7 +6,7 @@ int gitsetenv(const char *name, const char *value, int replace)
 	size_t namelen, valuelen;
 	char *envstr;
 
-	if (!name || !value) {
+	if (!name || strchr(name, '=') || !value) {
 		errno = EINVAL;
 		return -1;
 	}