From: Gerrit Pape Date: Tue, 24 Feb 2009 08:58:16 +0000 (+0000) Subject: Install builtins with the user and group of the installing personality X-Git-Tag: v1.6.2-rc2~11 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=6a0861a8a3295395238c8126c6e74c66b715c595;p=git.git Install builtins with the user and group of the installing personality If 'make install' was run with sufficient privileges, then the installed builtins in gitexecdir, which are either hardlinked, symlinked, or copied, would receive the user and group of whoever built git. With this commit the initial hardlink or copy is done from the installation tree and not the build tree to fix this. Signed-off-by: Gerrit Pape Signed-off-by: Junio C Hamano --- diff --git a/Makefile b/Makefile index b040a96e5..0675c43e7 100644 --- a/Makefile +++ b/Makefile @@ -1468,8 +1468,8 @@ endif bindir=$$(cd '$(DESTDIR_SQ)$(bindir_SQ)' && pwd) && \ execdir=$$(cd '$(DESTDIR_SQ)$(gitexec_instdir_SQ)' && pwd) && \ { $(RM) "$$execdir/git-add$X" && \ - ln git-add$X "$$execdir/git-add$X" 2>/dev/null || \ - cp git-add$X "$$execdir/git-add$X"; } && \ + ln "$$bindir/git$X" "$$execdir/git-add$X" 2>/dev/null || \ + cp "$$bindir/git$X" "$$execdir/git-add$X"; } && \ { for p in $(filter-out git-add$X,$(BUILT_INS)); do \ $(RM) "$$execdir/$$p" && \ ln "$$execdir/git-add$X" "$$execdir/$$p" 2>/dev/null || \