From: Alex Riesen <raa.lkml@gmail.com>
Date: Thu, 23 Apr 2009 19:18:09 +0000 (+0200)
Subject: Explain seemingly pointless use of system in difftool
X-Git-Tag: v1.6.3-rc2~5
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=677fbff88f368ed6ac52438ddbb530166ec1d5d1;p=git.git

Explain seemingly pointless use of system in difftool

Portability reasons.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/git-difftool.perl b/git-difftool.perl
index bd828c2a6..ba5e60a45 100755
--- a/git-difftool.perl
+++ b/git-difftool.perl
@@ -82,5 +82,11 @@ sub generate_command
 }
 
 setup_environment();
+
+# ActiveState Perl for Win32 does not implement POSIX semantics of
+# exec* system call. It just spawns the given executable and finishes
+# the starting program, exiting with code 0.
+# system will at least catch the errors returned by git diff,
+# allowing the caller of git difftool better handling of failures.
 my $rc = system(generate_command());
 exit($rc | ($rc >> 8));