From: Junio C Hamano Date: Mon, 18 Apr 2005 22:07:24 +0000 (-0700) Subject: [PATCH] show-diff.c: adjust default format for the Linux kernel. X-Git-Tag: v0.99~822 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=5a6ad74623571a1479af7914ec16783a9566e4b2;p=git.git [PATCH] show-diff.c: adjust default format for the Linux kernel. This patch adjusts the default output format of show-diff to match the Linux kernel style, recommended in Documentation/SubmittingPatches. Signed-off-by: Junio C Hamano Signed-off-by: Linus Torvalds --- diff --git a/show-diff.c b/show-diff.c index 40bc187bd..32d2fceaf 100644 --- a/show-diff.c +++ b/show-diff.c @@ -5,7 +5,7 @@ */ #include "cache.h" -static char *diff_cmd = "diff -L '%s' -u -N - '%s'"; +static char *diff_cmd = "diff -L 'a/%s' -L 'b/%s' -p -u - '%s'"; /* Help to copy the thing properly quoted for the shell safety. * any single quote is replaced with '\'', and the caller is @@ -52,11 +52,12 @@ static void show_differences(char *name, char *label, void *old_contents, FILE *f; char *name_sq = sq_expand(name); char *label_sq = (name != label) ? sq_expand(label) : name_sq; - int cmd_size = strlen(name_sq) + strlen(label_sq) + strlen(diff_cmd); + int cmd_size = strlen(name_sq) + + strlen(label_sq) * 2 + strlen(diff_cmd); char *cmd = malloc(cmd_size); fflush(stdout); - snprintf(cmd, cmd_size, diff_cmd, label_sq, name_sq); + snprintf(cmd, cmd_size, diff_cmd, label_sq, label_sq, name_sq); f = popen(cmd, "w"); if (old_size) fwrite(old_contents, old_size, 1, f);