From: Brian Gernhardt <brian@gernhardtsoftware.com>
Date: Wed, 20 Oct 2010 05:57:11 +0000 (-0400)
Subject: t/gitweb-lib: Don't pass constant to decode_utf8
X-Git-Tag: v1.7.3.3~7^2
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=598df7bcb775a247cc3f20c5a8b1b36955b16462;p=git.git

t/gitweb-lib: Don't pass constant to decode_utf8

Encode.pm started updating the string to decode in-place when a second
argument is passed in version 2.40.

This causes 'decode_utf8("", Encode::FB_CROAK)' to die with a message
like:

  Modification of a read-only value attempted at .../Encode.pm line 216.

Work around this by passing an empty variable instead of a constant
string.

Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com>
Acked-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh
index 81ef2a096..1b9523d02 100644
--- a/t/gitweb-lib.sh
+++ b/t/gitweb-lib.sh
@@ -80,7 +80,7 @@ if ! test_have_prereq PERL; then
 	test_done
 fi
 
-perl -MEncode -e 'decode_utf8("", Encode::FB_CROAK)' >/dev/null 2>&1 || {
+perl -MEncode -e '$e="";decode_utf8($e, Encode::FB_CROAK)' >/dev/null 2>&1 || {
     skip_all='skipping gitweb tests, perl version is too old'
     test_done
 }