From: pjrm <pjrm@users.sourceforge.net>
Date: Mon, 13 Jul 2009 03:14:38 +0000 (+0000)
Subject: doc: add TODO comment for handling hrefs better.
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=50459c2f835dde920d4fedb7c99449ad96c3cbe7;p=inkscape.git

doc: add TODO comment for handling hrefs better.
---

diff --git a/src/display/nr-filter-image.cpp b/src/display/nr-filter-image.cpp
index 9679e56e7..2b799f8d2 100644
--- a/src/display/nr-filter-image.cpp
+++ b/src/display/nr-filter-image.cpp
@@ -107,6 +107,13 @@ int FilterImage::render(FilterSlot &slot, FilterUnits const &units) {
 
     if (!image_pixbuf){
         try {
+            /* TODO: If feImageHref is absolute, then use that (preferably handling the
+             * case that it's not a file URI).  Otherwise, go up the tree looking
+             * for an xml:base attribute, and use that as the base URI for resolving
+             * the relative feImageHref URI.  Otherwise, if document && document->base,
+             * then use that as the base URI.  Otherwise, use feImageHref directly
+             * (i.e. interpreting it as relative to our current working directory).
+             * (See http://www.w3.org/TR/xmlbase/#resolution .) */
             gchar *fullname = feImageHref;
             if ( !g_file_test( fullname, G_FILE_TEST_EXISTS ) ) {
                 // Try to load from relative postion combined with document base