From: Thomas Rast Date: Tue, 1 Jul 2008 09:47:04 +0000 (+0200) Subject: Fix 'git show' on signed tag of signed tag of commit X-Git-Tag: v1.5.6.2~8 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=4f3dcc2;p=git.git Fix 'git show' on signed tag of signed tag of commit The cmd_show loop resolves tags by showing them, then pointing the object to the 'tagged' member. However, this object is not fully initialized; it only contains the SHA1. (This resulted in a segfault if there were two levels of tags.) We apply parse_object to get a full object. Noticed by Kalle Olavi Niemitalo on IRC. Signed-off-by: Thomas Rast Signed-off-by: Junio C Hamano --- diff --git a/builtin-log.c b/builtin-log.c index 9817d6fbe..9979e37f3 100644 --- a/builtin-log.c +++ b/builtin-log.c @@ -360,7 +360,7 @@ int cmd_show(int argc, const char **argv, const char *prefix) t->tag, diff_get_color_opt(&rev.diffopt, DIFF_RESET)); ret = show_object(o->sha1, 1, &rev); - objects[i].item = (struct object *)t->tagged; + objects[i].item = parse_object(t->tagged->sha1); i--; break; }