From: Linus Torvalds Date: Mon, 1 Aug 2005 19:11:53 +0000 (-0700) Subject: [PATCH] Fix sparse warnings X-Git-Tag: v0.99.3~2 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=4d8fa916c9ff89613234f41b9222a2b679bce5c3;p=git.git [PATCH] Fix sparse warnings A few sparse warnings have crept in again since I checked last time: undeclared variables with global scope. Fix them by marking the private variables properly "static". Signed-off-by: Linus Torvalds Signed-off-by: Junio C Hamano --- diff --git a/daemon.c b/daemon.c index eeff9e7b0..b7d60918e 100644 --- a/daemon.c +++ b/daemon.c @@ -71,13 +71,13 @@ static int max_connections = 25; /* These are updated by the signal handler */ static volatile unsigned int children_reaped = 0; -pid_t dead_child[MAX_CHILDREN]; +static pid_t dead_child[MAX_CHILDREN]; /* These are updated by the main loop */ static unsigned int children_spawned = 0; static unsigned int children_deleted = 0; -struct child { +static struct child { pid_t pid; socklen_t addrlen; struct sockaddr_storage address; diff --git a/rev-cache.c b/rev-cache.c index f908ce7a3..6344d6224 100644 --- a/rev-cache.c +++ b/rev-cache.c @@ -5,7 +5,7 @@ struct rev_cache **rev_cache; int nr_revs, alloc_revs; -struct rev_list_elem *rle_free; +static struct rev_list_elem *rle_free; #define BATCH_SIZE 512 diff --git a/server-info.c b/server-info.c index 3dd201afb..2b3aecab4 100644 --- a/server-info.c +++ b/server-info.c @@ -62,7 +62,7 @@ static int update_info_refs(int force) } /* packs */ -struct pack_info { +static struct pack_info { unsigned long latest; struct packed_git *p; int old_num;