From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Sat, 7 Jul 2007 18:19:08 +0000 (+0200)
Subject: diff-lib.c: don't strdup twice
X-Git-Tag: v1.5.3-rc1~57
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=4d3f4b80e49275c7eaf6ba0dbddd6180957926b9;p=git.git

diff-lib.c: don't strdup twice

The static function read_directory in diff-lib.c is only ever called
with struct path_list lists with .strdup_paths turned on, i.e.
path_list_insert will strdup the paths for us (again).  Let's take
advantage of that and stop doing it twice.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/diff-lib.c b/diff-lib.c
index 7fb19c7b8..92c0e39ad 100644
--- a/diff-lib.c
+++ b/diff-lib.c
@@ -24,7 +24,7 @@ static int read_directory(const char *path, struct path_list *list)
 
 	while ((e = readdir(dir)))
 		if (strcmp(".", e->d_name) && strcmp("..", e->d_name))
-			path_list_insert(xstrdup(e->d_name), list);
+			path_list_insert(e->d_name, list);
 
 	closedir(dir);
 	return 0;