From: Daniel Barkalow <barkalow@iabervon.org>
Date: Sun, 4 Dec 2005 16:59:37 +0000 (-0500)
Subject: Warn when send-pack does nothing
X-Git-Tag: v0.99.9m^2~86
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=4c353e890c0107a8e733ab11634da21844ec38ba;p=git.git

Warn when send-pack does nothing

If you try to push into an empty repository with no ref arguments to
git push, it doesn't do anything and doesn't say anything. This adds a
warning when send-pack isn't going to push anything, so you don't
assume that it silently did what you wanted.

Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/send-pack.c b/send-pack.c
index 2a14b0084..f61c15c82 100644
--- a/send-pack.c
+++ b/send-pack.c
@@ -190,6 +190,12 @@ static int send_pack(int in, int out, int nr_refspec, char **refspec)
 	if (match_refs(local_refs, remote_refs, &remote_tail,
 		       nr_refspec, refspec, send_all))
 		return -1;
+
+	if (!remote_refs) {
+		fprintf(stderr, "No refs in common and none specified; doing nothing.\n");
+		return 0;
+	}
+
 	/*
 	 * Finally, tell the other end!
 	 */