From: Jeff King Date: Fri, 18 Nov 2011 11:11:28 +0000 (-0500) Subject: refresh_index: rename format variables X-Git-Tag: v1.7.8.2~24^2~1 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=4bd4e73093eb741a87b7d80bc84469d880f4e2f3;p=git.git refresh_index: rename format variables When refreshing the index, for modified (or unmerged) files we will print "needs update" (or "needs merge") for plumbing, or line similar to the output from "diff --name-status" for porcelain. The variables holding which type of message to show are named after the plumbing messages. However, as we begin to differentiate more cases at the porcelain level (with the plumbing message staying the same), that naming scheme will become awkward. Instead, name the variables after which case we found (modified or unmerged), not what we will output. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/read-cache.c b/read-cache.c index 8e69ea3ee..f19b2f17a 100644 --- a/read-cache.c +++ b/read-cache.c @@ -1105,11 +1105,11 @@ int refresh_index(struct index_state *istate, unsigned int flags, const char **p int first = 1; int in_porcelain = (flags & REFRESH_IN_PORCELAIN); unsigned int options = really ? CE_MATCH_IGNORE_VALID : 0; - const char *needs_update_fmt; - const char *needs_merge_fmt; + const char *modified_fmt; + const char *unmerged_fmt; - needs_update_fmt = (in_porcelain ? "M\t%s\n" : "%s: needs update\n"); - needs_merge_fmt = (in_porcelain ? "U\t%s\n" : "%s: needs merge\n"); + modified_fmt = (in_porcelain ? "M\t%s\n" : "%s: needs update\n"); + unmerged_fmt = (in_porcelain ? "U\t%s\n" : "%s: needs merge\n"); for (i = 0; i < istate->cache_nr; i++) { struct cache_entry *ce, *new; int cache_errno = 0; @@ -1125,7 +1125,7 @@ int refresh_index(struct index_state *istate, unsigned int flags, const char **p i--; if (allow_unmerged) continue; - show_file(needs_merge_fmt, ce->name, in_porcelain, &first, header_msg); + show_file(unmerged_fmt, ce->name, in_porcelain, &first, header_msg); has_errors = 1; continue; } @@ -1148,7 +1148,7 @@ int refresh_index(struct index_state *istate, unsigned int flags, const char **p } if (quiet) continue; - show_file(needs_update_fmt, ce->name, in_porcelain, &first, header_msg); + show_file(modified_fmt, ce->name, in_porcelain, &first, header_msg); has_errors = 1; continue; }