From: Brandon Casey Date: Sat, 20 Mar 2010 00:10:20 +0000 (-0500) Subject: t/t5505-remote.sh: escape * to prevent interpretation by shell as glob X-Git-Tag: v1.7.1-rc0~19^2 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=49de47cfb2d717b64cf93c5abeeefb87ee483de0;p=git.git t/t5505-remote.sh: escape * to prevent interpretation by shell as glob This test is supposed to check that git-remote correctly refuses to delete all URLS for the specified remote which match the '.*' regular expression. Since the '*' was not protected, it was interpreted by the shell as a file glob and expanded before being passed to git-remote. The call to git-remote still exited non-zero in this case, and the overall test still passed, but it exited non-zero because git-remote was passed the incorrect number of arguments, not for the reason it was supposed to fail. Correct the test by escaping the '*'. Signed-off-by: Brandon Casey Signed-off-by: Junio C Hamano --- diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh index e7afe9e16..acfea06b8 100755 --- a/t/t5505-remote.sh +++ b/t/t5505-remote.sh @@ -662,7 +662,7 @@ test_expect_success 'remote set-url --add bbb' ' ' test_expect_success 'remote set-url --delete .*' ' - test_must_fail git remote set-url --delete someremote .* && + test_must_fail git remote set-url --delete someremote .\* && echo "YYY" >expect && echo baz >>expect && echo bbb >>expect &&