From: Junio C Hamano Date: Fri, 3 Dec 2010 20:28:00 +0000 (-0800) Subject: t9300: remove unnecessary use of /dev/stdin X-Git-Tag: v1.7.4-rc0~30^2~1 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=491e359c949ef7b7ed3fd24ba59f1b7e4cc17e87;p=git.git t9300: remove unnecessary use of /dev/stdin We really shouldn't be using these funny /dev/* files that did not exist in V7 UNIX in our tests when we do not have to. Output from $ git grep -n -e /dev/ --and --not -e /dev/null t/ tells us that, aside from use of /dev/urandom in apache.conf used in http tests, "dd if=/dev/stdin" added recently to t/t9300-fast-import.sh are the only offenders, and "dd" reads from the standard input by default, so removing them should be straightforward. Reported-by: Thomas Rast Signed-off-by: Junio C Hamano --- diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh index d615d04a3..055ddc6dd 100755 --- a/t/t9300-fast-import.sh +++ b/t/t9300-fast-import.sh @@ -1794,7 +1794,7 @@ test_expect_success PIPE 'R: copy using cat-file' ' read blob_id type size <&3 && echo "$blob_id $type $size" >response && - dd if=/dev/stdin of=blob bs=$size count=1 <&3 && + dd of=blob bs=$size count=1 <&3 && read newline <&3 && cat <