From: Johannes Schindelin Date: Fri, 8 Aug 2008 02:29:35 +0000 (+0200) Subject: clone --mirror: avoid storing repeated tags X-Git-Tag: v1.6.0-rc3~30 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=468386a956c09ff59dd2b8fd681e162b2e167392;p=git.git clone --mirror: avoid storing repeated tags With --mirror, clone asks for refs/* already, so it does not need to ask for ref/tags/*, too. Noticed by Cesar Eduardo Barros. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- diff --git a/builtin-clone.c b/builtin-clone.c index 8612d59dd..c0e308643 100644 --- a/builtin-clone.c +++ b/builtin-clone.c @@ -330,7 +330,8 @@ static struct ref *write_remote_refs(const struct ref *refs, struct ref *r; get_fetch_map(refs, refspec, &tail, 0); - get_fetch_map(refs, tag_refspec, &tail, 0); + if (!option_mirror) + get_fetch_map(refs, tag_refspec, &tail, 0); for (r = local_refs; r; r = r->next) add_extra_ref(r->peer_ref->name, r->old_sha1, 0); diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh index a13b6f9d3..59c65fef2 100755 --- a/t/t5601-clone.sh +++ b/t/t5601-clone.sh @@ -95,4 +95,16 @@ test_expect_success 'clone --bare names the local repository .git' ' ' +test_expect_success 'clone --mirror does not repeat tags' ' + + (cd src && + git tag some-tag HEAD) && + git clone --mirror src mirror2 && + (cd mirror2 && + git show-ref 2> clone.err > clone.out) && + test_must_fail grep Duplicate mirror2/clone.err && + grep some-tag mirror2/clone.out + +' + test_done