From: Ramsay Jones Date: Tue, 21 Sep 2010 17:45:09 +0000 (+0100) Subject: t1503: Fix arithmetic expansion syntax error when using dash X-Git-Tag: v1.7.3.1~14 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=4098f6717b8137493dddfc1a28a72b25769ed7bc;p=git.git t1503: Fix arithmetic expansion syntax error when using dash On systems which have dash as /bin/sh, such as Ubuntu, the final test (master@{n} for various n) fails with a syntax error while processing an arithmetic expansion. The syntax error is caused by using a bare name ('N') as a variable reference in the expression. In order to avoid the syntax error, we spell the variable reference as '$N' rather than simply 'N'. Signed-off-by: Ramsay Jones Signed-off-by: Junio C Hamano --- diff --git a/t/t1503-rev-parse-verify.sh b/t/t1503-rev-parse-verify.sh index 100f857b1..813cc1b3e 100755 --- a/t/t1503-rev-parse-verify.sh +++ b/t/t1503-rev-parse-verify.sh @@ -106,8 +106,8 @@ test_expect_success 'use --default' ' test_expect_success 'master@{n} for various n' ' N=$(git reflog | wc -l) && - Nm1=$((N-1)) && - Np1=$((N+1)) && + Nm1=$(($N-1)) && + Np1=$(($N+1)) && git rev-parse --verify master@{0} && git rev-parse --verify master@{1} && git rev-parse --verify master@{$Nm1} &&