From: cilix42 <cilix42@users.sourceforge.net>
Date: Wed, 26 Dec 2007 01:57:30 +0000 (+0000)
Subject: Don't store special attributes/types when saving 3D boxes to plain SVG (so that they... 
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=403939b9b80571887cc36b75f3054af73d0b9e7f;p=inkscape.git

Don't store special attributes/types when saving 3D boxes to plain SVG (so that they show up correctly when reopening files).
---

diff --git a/src/box3d-side.cpp b/src/box3d-side.cpp
index d1111aacb..e4f60075b 100644
--- a/src/box3d-side.cpp
+++ b/src/box3d-side.cpp
@@ -119,17 +119,17 @@ box3d_side_write (SPObject *object, Inkscape::XML::Node *repr, guint flags)
     Box3DSide *side = SP_BOX3D_SIDE (object);
 
     if ((flags & SP_OBJECT_WRITE_BUILD) && !repr) {
-        g_print ("Do we ever end up here?\n");
+        // this is where we end up when saving as plain SVG (also in other circumstances?)
+        // thus we don' set "sodipodi:type" so that the box is only saved as an ordinary svg:path
         Inkscape::XML::Document *xml_doc = sp_document_repr_doc(SP_OBJECT_DOCUMENT(object));
         repr = xml_doc->createElement("svg:path");
-        repr->setAttribute("sodipodi:type", "inkscape:box3dside"); // FIXME: Does this double the 
     }
 
     if (flags & SP_OBJECT_WRITE_EXT) {
         sp_repr_set_int(repr, "inkscape:box3dsidetype", side->dir1 ^ side->dir2 ^ side->front_or_rear);
     }
 
-    sp_shape_set_shape ((SPShape *) object); // FIXME: necessary? YES!
+    sp_shape_set_shape ((SPShape *) object);
 
     /* Duplicate the path */
     SPCurve *curve = ((SPShape *) object)->curve;
diff --git a/src/box3d.cpp b/src/box3d.cpp
index b1f59253f..4044b5647 100644
--- a/src/box3d.cpp
+++ b/src/box3d.cpp
@@ -280,10 +280,10 @@ static Inkscape::XML::Node *box3d_write(SPObject *object, Inkscape::XML::Node *r
     SPBox3D *box = SP_BOX3D(object);
 
     if ((flags & SP_OBJECT_WRITE_BUILD) && !repr) {
-        g_print ("Do we ever end up here?\n");
+        // this is where we end up when saving as plain SVG (also in other circumstances?)
+        // thus we don' set "sodipodi:type" so that the box is only saved as an ordinary svg:g
         Inkscape::XML::Document *xml_doc = sp_document_repr_doc(SP_OBJECT_DOCUMENT(object));
         repr = xml_doc->createElement("svg:g");
-        repr->setAttribute("sodipodi:type", "inkscape:box3d");
     }
 
     if (flags & SP_OBJECT_WRITE_EXT) {