From: Andy Parkins <andyparkins@gmail.com>
Date: Fri, 2 Mar 2007 19:29:20 +0000 (+0000)
Subject: Sample update hook: typofix and modernization to use "git log"
X-Git-Tag: v1.5.1-rc1~107
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=3d84df43e134d01cb790ddd47a14963ecd110152;p=git.git

Sample update hook: typofix and modernization to use "git log"

Instead of using antiquated "git-rev-parse | git-rev-list"
pipeline, it is easier to use "git-rev-list" or "git-log" these
days, as Linus points out.

While we are at it, fix the typo on variable name $newref that
should be $newrev.

Signed-off-by: Andy Parkins <andyparkins@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/templates/hooks--update b/templates/hooks--update
index fd1f73d6a..4af2fe8d9 100644
--- a/templates/hooks--update
+++ b/templates/hooks--update
@@ -148,7 +148,7 @@ case "$refname_type" in
 			# This shows all log entries that are not already covered by
 			# another ref - i.e. commits that are now accessible from this
 			# ref that were previously not accessible
-			git-rev-parse --not --all | git-rev-list --stdin --pretty $newref
+			git log $newrev --not --all
 			echo $LOGEND
 		else
 			# oldrev is valid
@@ -165,7 +165,7 @@ case "$refname_type" in
 			baserev=$(git-merge-base $oldrev $newrev)
 
 			# Commit with a parent
-			for rev in $(git-rev-parse --not --all | git-rev-list --stdin $newrev ^$baserev)
+			for rev in $(git-rev-list $newrev --not $baserev --all)
 			do
 				revtype=$(git-cat-file -t "$rev")
 				echo "       via  $rev ($revtype)"
@@ -190,12 +190,11 @@ case "$refname_type" in
 			fi
 			echo ""
 			echo $LOGBEGIN
-			git-rev-parse --not --all |
-			git-rev-list --stdin --pretty $newrev ^$baserev
+			git log $newrev --not $baserev --all
 			echo $LOGEND
 			echo ""
 			echo "Diffstat:"
-			git-diff-tree --no-color --stat -M -C --find-copies-harder $newrev ^$baserev
+			git-diff-tree --no-color --stat -M -C --find-copies-harder $baserev..$newrev
 		fi
 		;;
 	"annotated tag")