From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Date: Tue, 22 Jul 2008 20:40:41 +0000 (+0100)
Subject: builtin-commit: Two trivial style-cleanups
X-Git-Tag: v1.6.0-rc1~55
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=3b6aeb3cc37c8ef934850fb01e1de48e12cf3aac;p=git.git

builtin-commit: Two trivial style-cleanups

Pierre Habouzit noticed that two variables were not static which should
have been, and that adding "\n\n" is better than adding '\n' twice.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin-commit.c b/builtin-commit.c
index 97e64de31..7434797d1 100644
--- a/builtin-commit.c
+++ b/builtin-commit.c
@@ -68,8 +68,8 @@ static enum {
 static char *cleanup_arg;
 
 static int use_editor = 1, initial_commit, in_merge;
-const char *only_include_assumed;
-struct strbuf message;
+static const char *only_include_assumed;
+static struct strbuf message;
 
 static int opt_parse_m(const struct option *opt, const char *arg, int unset)
 {
@@ -78,8 +78,7 @@ static int opt_parse_m(const struct option *opt, const char *arg, int unset)
 		strbuf_setlen(buf, 0);
 	else {
 		strbuf_addstr(buf, arg);
-		strbuf_addch(buf, '\n');
-		strbuf_addch(buf, '\n');
+		strbuf_addstr(buf, "\n\n");
 	}
 	return 0;
 }