From: jaspervdg <jaspervdg@users.sourceforge.net>
Date: Fri, 21 Mar 2008 08:35:54 +0000 (+0000)
Subject: Replace char buffer by std::string to prevent buffer overflow when computing the... 
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=3a13f949a6708458a8b757a4c5855b08baeaef90;p=inkscape.git

Replace char buffer by std::string to prevent buffer overflow when computing the new PATH.
---

diff --git a/src/main.cpp b/src/main.cpp
index d86b60540..b5ed8305d 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -423,7 +423,7 @@ static int _win32_set_inkscape_env(char *argv0)
     CHAR szFile[_MAX_FNAME];
     CHAR szExt[_MAX_EXT];
 
-    CHAR tmp[_MAX_EXT];
+    std::string tmp;
 
     if (GetModuleFileName(NULL, szFullPath, sizeof(szFullPath)) == 0) {
         strcpy(szFullPath, argv0);
@@ -434,32 +434,32 @@ static int _win32_set_inkscape_env(char *argv0)
     strcat(szFullPath, szDir);
 
     char *oldenv = getenv("PATH");
-	strcpy(tmp, "PATH=");
-    strcat(tmp, szFullPath);
-    strcat(tmp, ";");
-    strcat(tmp, szFullPath);
-    strcat(tmp, "python;");
-    strcat(tmp, szFullPath);
-    strcat(tmp, "perl;");
+    tmp = "PATH=";
+    tmp += szFullPath;
+    tmp += ";";
+    tmp += szFullPath;
+    tmp += "python;";
+    tmp += szFullPath;
+    tmp += "perl";
     if(oldenv != NULL) {
-		strcat(tmp, ";");
-		strcat(tmp, oldenv);
-	}
-	_putenv(tmp);
+        tmp += ";";
+        tmp += oldenv;
+    }
+    _putenv(tmp.c_str());
 
     oldenv = getenv("PYTHONPATH");
-    strcpy(tmp, "PYTHONPATH=");
-    strcat(tmp, szFullPath);
-    strcat(tmp, "python;");
-    strcat(tmp, szFullPath);
-    strcat(tmp, "python\\Lib;");
-    strcat(tmp, szFullPath);
-    strcat(tmp, "python\\DLLs");
+    tmp = "PYTHONPATH=";
+    tmp += szFullPath;
+    tmp += "python;";
+    tmp += szFullPath;
+    tmp += "python\\Lib;";
+    tmp += szFullPath;
+    tmp += "python\\DLLs";
     if(oldenv != NULL) {
-		strcat(tmp, ";");
-		strcat(tmp, oldenv);
-	}
-	_putenv(tmp);
+        tmp += ";";
+        tmp += oldenv;
+    }
+    _putenv(tmp.c_str());
 
     return 0;
 }