From: Junio C Hamano Date: Sat, 7 Apr 2007 06:04:55 +0000 (-0700) Subject: git-push reports the URL after failing. X-Git-Tag: v1.5.2-rc0~68^2~1 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=39878b0cb7d0afc3ff4c8adb715815f116188178;p=git.git git-push reports the URL after failing. This came up on #git when somebody was getting 'unable to create ./objects/tmp_oXXXX' but sweared he had write permission to that directory. It turned out that the repository URL was changed and he was accessing a repository he does not have a write permission anymore. I am not sure how much this would have helped somebody who believed he was accessing location when the permission of that location was changed while he was looking the other way, though. But giving more information on the error path would be better, and the next change would be helped with this as well. Signed-off-by: Junio C Hamano --- diff --git a/builtin-push.c b/builtin-push.c index 70b1168fa..23143be54 100644 --- a/builtin-push.c +++ b/builtin-push.c @@ -339,6 +339,8 @@ static int do_push(const char *repo) err = run_command_v_opt(argv, RUN_GIT_CMD); if (!err) continue; + + error("failed to push to '%s'", uri[i]); switch (err) { case -ERR_RUN_COMMAND_FORK: die("unable to fork for %s", sender);