From: Sebastian Harl <sh@tokkee.org>
Date: Wed, 28 Jan 2015 15:17:47 +0000 (+0100)
Subject: client: Don't use select() before reading from a client connection.
X-Git-Tag: sysdb-0.7.0~41
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=36b043db0dab4b3add701ca62363e97619b6e15c;p=sysdb.git

client: Don't use select() before reading from a client connection.

This doesn't work well if the connection buffers data (like with the upcoming
SSL support).
---

diff --git a/src/client/sock.c b/src/client/sock.c
index cb506a5..f9929da 100644
--- a/src/client/sock.c
+++ b/src/client/sock.c
@@ -384,9 +384,6 @@ sdb_client_recv(sdb_client_t *client,
 	while (42) {
 		ssize_t status;
 
-		if (sdb_select(client->fd, SDB_SELECTIN))
-			return -1;
-
 		errno = 0;
 		status = client->read(client, buf, req);
 		if (status < 0) {