From: Björn Steinbrink <B.Steinbrink@gmx.de>
Date: Mon, 5 Nov 2007 19:36:33 +0000 (+0100)
Subject: git-commit.sh: Fix usage checks regarding paths given when they do not make sense
X-Git-Tag: v1.5.3.7~15^2~1
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=34cb704a9b8b45ff3e1342678c5892e1ee6e27f5;p=git.git

git-commit.sh: Fix usage checks regarding paths given when they do not make sense

The checks that looked for paths given to git-commit in addition to
--all or --interactive expected only 3 values, while the case statement
actually provides 4, so the check was never triggered.

The bug was introduced in 6cbf07efc5702351897dee4742525c9b9f7828ac when
the case statement was extended to handle --interactive.

Signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/git-commit.sh b/git-commit.sh
index ab43217be..5e3908f2c 100755
--- a/git-commit.sh
+++ b/git-commit.sh
@@ -322,9 +322,9 @@ unset only
 case "$all,$interactive,$also,$#" in
 *t,*t,*)
 	die "Cannot use -a, --interactive or -i at the same time." ;;
-t,,[1-9]*)
+t,,,[1-9]*)
 	die "Paths with -a does not make sense." ;;
-,t,[1-9]*)
+,t,,[1-9]*)
 	die "Paths with --interactive does not make sense." ;;
 ,,t,0)
 	die "No paths with -i does not make sense." ;;