From: Jeff King Date: Tue, 19 Feb 2008 16:25:01 +0000 (-0500) Subject: push: indicate partialness of error message X-Git-Tag: v1.5.4.3~10 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=2b8130c338715936fcda82e734e76e86a33316aa;p=git.git push: indicate partialness of error message The existing message indicates that an error occured during push, but it is unclear whether _any_ refs were actually pushed (even though the status table above shows which were pushed successfully and which were not, the message "failed to push" implies a total failure). By indicating that "some refs" failed, we hopefully indicate to the user that the table above contains the details. We could also put in an explicit "see above for details" message, but it seemed to clutter the output quite a bit (both on a line of its own, or at the end of the error line, which inevitably wraps). This could also be made more fancy if the transport mechanism passed back more details on how many refs succeeded and failed: error: failed to push %d out of %d refs to '%s' Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/builtin-push.c b/builtin-push.c index c8cb63e23..9f727c00f 100644 --- a/builtin-push.c +++ b/builtin-push.c @@ -90,7 +90,7 @@ static int do_push(const char *repo, int flags) if (!err) continue; - error("failed to push to '%s'", remote->url[i]); + error("failed to push some refs to '%s'", remote->url[i]); errs++; } return !!errs;