From: Max Kellermann <max@duempel.org>
Date: Fri, 19 Sep 2008 12:48:22 +0000 (+0200)
Subject: browser: use mpdclient_filelist_find_song() in set_highlight()
X-Git-Tag: v0.12_alpha1~224
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=28a463b53369e9f26d6fb0a755af588faac38e18;p=ncmpc.git

browser: use mpdclient_filelist_find_song() in set_highlight()

A song should not be twice in the browser.  Simplify set_highlight()
by finding the entry with mpdclient_filelist_find_song().
---

diff --git a/src/screen_browser.c b/src/screen_browser.c
index dbc7ada..828cbe2 100644
--- a/src/screen_browser.c
+++ b/src/screen_browser.c
@@ -54,26 +54,17 @@ clear_highlights(mpdclient_filelist_t *fl)
 static void
 set_highlight(mpdclient_filelist_t *fl, mpd_Song *song, int highlight)
 {
-	GList *list = g_list_first(fl->list);
-
-	assert(song != NULL);
+	struct filelist_entry *entry = mpdclient_filelist_find_song(fl, song);
+	mpd_InfoEntity *entity;
 
-	while( list ) {
-		filelist_entry_t *entry = list->data;
-		mpd_InfoEntity *entity  = entry->entity;
+	if (entry == NULL)
+		return;
 
-		if( entity && entity->type==MPD_INFO_ENTITY_TYPE_SONG ) {
-			mpd_Song *song2 = entity->info.song;
-
-			if( strcmp(song->file, song2->file) == 0 ) {
-				if(highlight)
-					entry->flags |= HIGHLIGHT;
-				else
-					entry->flags &= ~HIGHLIGHT;
-			}
-		}
-		list = list->next;
-	}
+	entity = entry->entity;
+	if (highlight)
+		entry->flags |= HIGHLIGHT;
+	else
+		entry->flags &= ~HIGHLIGHT;
 }
 
 /* sync highlight flags with playlist */