From: Jay Soffian <jaysoffian@gmail.com>
Date: Wed, 20 Feb 2008 05:55:07 +0000 (-0500)
Subject: send-email: squelch warning due to comparing undefined $_ to ""
X-Git-Tag: v1.5.4.3~6
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=1ca3d6e;p=git.git

send-email: squelch warning due to comparing undefined $_ to ""

The check to see if initial_reply_to is defined was also comparing $_ to
"" for a reason I cannot ascertain (looking at the commit which made the
change didn't provide enlightenment), but if $_ is undefined, perl
generates a warning.

Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/git-send-email.perl b/git-send-email.perl
index a1a9d14b0..8e6f3b22c 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -406,7 +406,7 @@ if ($thread && !defined $initial_reply_to && $prompting) {
 
 	$initial_reply_to = $_;
 }
-if (defined $initial_reply_to && $_ ne "") {
+if (defined $initial_reply_to) {
 	$initial_reply_to =~ s/^\s*<?/</;
 	$initial_reply_to =~ s/>?\s*$/>/;
 }