From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 29 Sep 2009 06:40:08 +0000 (-0700)
Subject: builtin-mailinfo.c: check error status from rewind and ftruncate
X-Git-Tag: v1.6.5-rc3~11
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=1be224ba6e99f0ab34c998d7fa8023b76a15c8b6;p=git.git

builtin-mailinfo.c: check error status from rewind and ftruncate

A recent "cut at scissors" implementation rewinds and truncates
the output file to store the message when it sees a scissors mark,
but it did not check if these library calls succeeded.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
[sp: Use fseek as rewind returns void]
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---

diff --git a/builtin-mailinfo.c b/builtin-mailinfo.c
index d498b1cd2..c90cd312a 100644
--- a/builtin-mailinfo.c
+++ b/builtin-mailinfo.c
@@ -785,8 +785,10 @@ static int handle_commit_msg(struct strbuf *line)
 
 	if (use_scissors && is_scissors_line(line)) {
 		int i;
-		rewind(cmitmsg);
-		ftruncate(fileno(cmitmsg), 0);
+		if (fseek(cmitmsg, 0L, SEEK_SET))
+			die_errno("Could not rewind output message file");
+		if (ftruncate(fileno(cmitmsg), 0))
+			die_errno("Could not truncate output message file at scissors");
 		still_looking = 1;
 
 		/*