From: Greg Brockman <gdb@MIT.EDU>
Date: Tue, 20 Jul 2010 04:46:21 +0000 (-0400)
Subject: Check size of path buffer before writing into it
X-Git-Tag: v1.7.0.7~2^2^2~1^2
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=1b0b962d771fb734cbf273f216b487bb58dec7b9;p=git.git

Check size of path buffer before writing into it

This prevents a buffer overrun that could otherwise be triggered by
creating a file called '.git' with contents

  gitdir: (something really long)

Signed-off-by: Greg Brockman <gdb@mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/setup.c b/setup.c
index e3781b656..01e1a6a7c 100644
--- a/setup.c
+++ b/setup.c
@@ -153,6 +153,8 @@ static int is_git_directory(const char *suspect)
 	char path[PATH_MAX];
 	size_t len = strlen(suspect);
 
+	if (PATH_MAX <= len + strlen("/objects"))
+		die("Too long path: %.*s", 60, suspect);
 	strcpy(path, suspect);
 	if (getenv(DB_ENVIRONMENT)) {
 		if (access(getenv(DB_ENVIRONMENT), X_OK))