From: buliabyak <buliabyak@users.sourceforge.net>
Date: Tue, 23 Sep 2008 04:41:02 +0000 (+0000)
Subject: it's not a good idea to change key of arenaitem in the middle of an update; not only... 
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=19b6a289d8834235eba2b20a472e45f4710546b4;p=inkscape.git

it's not a good idea to change key of arenaitem in the middle of an update; not only this is unnecessary, but it results in a hard to catch windows-only crash
---

diff --git a/src/sp-shape.cpp b/src/sp-shape.cpp
index fbb9a60f6..6aec13bc9 100644
--- a/src/sp-shape.cpp
+++ b/src/sp-shape.cpp
@@ -288,16 +288,6 @@ sp_shape_update (SPObject *object, SPCtx *ctx, unsigned int flags)
         /* Dimension marker views */
         for (SPItemView *v = item->display; v != NULL; v = v->next) {
 
-            if (!v->arenaitem->key) {
-                /* Get enough keys for all, start, mid and end marker types,
-                ** and set this view's arenaitem key to the first of these keys.
-                */
-                NR_ARENA_ITEM_SET_KEY (
-                    v->arenaitem,
-                    sp_item_display_key_new (SP_MARKER_LOC_QTY)
-                    );
-            }
-
             for (int i = 0 ; i < SP_MARKER_LOC_QTY ; i++) {
                 if (shape->marker[i]) {
                     sp_marker_show_dimension ((SPMarker *) shape->marker[i],