From: Thomas Guyot-Sionnest Date: Sat, 5 Sep 2009 07:16:54 +0000 (-0400) Subject: Add a test that succeeds on check_snmp v1.4.13. Newer versions skip additional X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=181ac1e0182b01bc15188ada6f6239c652f55821;p=nagiosplug.git Add a test that succeeds on check_snmp v1.4.13. Newer versions skip additional lines so this new test fails on the current head. Note: check_snmp v1.4.13 with multi-line strings return somewhat v3 output; it's not exactly what the specs say but it doesn't appears to break them either. The fix could eventually supports both v2 and v3 output formats. --- diff --git a/plugins/tests/check_snmp.t b/plugins/tests/check_snmp.t index fcd15ea..5605b00 100755 --- a/plugins/tests/check_snmp.t +++ b/plugins/tests/check_snmp.t @@ -41,7 +41,7 @@ if ($ARGV[0] && $ARGV[0] eq "-d") { } } -my $tests = 2; +my $tests = 3; if (-x "./check_snmp") { plan tests => $tests; } else { @@ -53,4 +53,11 @@ my $res; $res = NPTest->testCmd( "./check_snmp -H 127.0.0.1 -C public -p $port_snmp -o .1.3.6.1.4.1.8072.3.2.67.0"); cmp_ok( $res->return_code, '==', 0, "Exit OK when querying a multi-line string" ); like($res->output, '/^SNMP OK - /', "String contains SNMP OK"); +like($res->output, '/'.quotemeta('SNMP OK - "Cisco Internetwork Operating System SoftwareIOS (tm) Catalyst 4000 L3 Switch Software (cat4000-I9K91S-M), Version +12.2(20)EWA, RELEASE SOFTWARE (fc1) +Technical Support: http://www.cisco.com/techsupport +Copyright (c) 1986-2004 by cisco Systems, Inc. +"').'/m', "String contains all lines"); + +print $res->output;