From: Jakub Narebski <jnareb@gmail.com>
Date: Sat, 5 Aug 2006 10:55:20 +0000 (+0200)
Subject: gitweb: Separate input validation and dispatch, add comment about opml action
X-Git-Tag: v1.4.3-rc1~274^2~17
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=154b4d78cf35025268ed74c45f182b25ebaf4acc;p=git.git

gitweb: Separate input validation and dispatch, add comment about opml action

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index b268b6344..7f4387fde 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -71,6 +71,7 @@ if (! -d $git_temp) {
 	mkdir($git_temp, 0700) || die_error("Couldn't mkdir $git_temp");
 }
 
+# ======================================================================
 # input validation and dispatch
 our $action = $cgi->param('a');
 if (defined $action) {
@@ -78,6 +79,7 @@ if (defined $action) {
 		undef $action;
 		die_error(undef, "Invalid action parameter.");
 	}
+	# action which does not check rest of parameters
 	if ($action eq "opml") {
 		git_opml();
 		exit;