From: Linus Torvalds <torvalds@g5.osdl.org>
Date: Tue, 5 Jul 2005 19:12:50 +0000 (-0700)
Subject: Remove unnecessary usage of strncmp() in git-rev-list arg parsing.
X-Git-Tag: v0.99~70
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=12ba7eaf1d8188ff85439abb98c5ce64cc81b319;p=git.git

Remove unnecessary usage of strncmp() in git-rev-list arg parsing.

Not only is it unnecessary, it incorrectly allows extraneous characters
at the end of the argument.

Junio noticed the --merge-order thing, and Jon points out that if we fix
that one, we should fix --show-breaks too.
---

diff --git a/rev-list.c b/rev-list.c
index 825006374..0d3c7741a 100644
--- a/rev-list.c
+++ b/rev-list.c
@@ -462,11 +462,11 @@ int main(int argc, char **argv)
 			limited = 1;
 			continue;
 		}
-		if (!strncmp(arg, "--merge-order", 13)) {
+		if (!strcmp(arg, "--merge-order")) {
 		        merge_order = 1;
 			continue;
 		}
-		if (!strncmp(arg, "--show-breaks", 13)) {
+		if (!strcmp(arg, "--show-breaks")) {
 			show_breaks = 1;
 			continue;
 		}