From: Shawn O. Pearce Date: Thu, 27 Aug 2009 00:39:45 +0000 (-0700) Subject: git-gui: Ensure submodule path is quoted properly X-Git-Tag: v1.6.6-rc0~96^2~3 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=118d938812f3fc660f43bad9b546e7dadc3571a9;p=git.git git-gui: Ensure submodule path is quoted properly When quoting an arbitrary user string in Tcl, its better to use [list ...] than to use {...}, in case the user string has spaces or { embedded within it. Signed-off-by: Shawn O. Pearce --- diff --git a/lib/diff.tcl b/lib/diff.tcl index d593323ae..bd5d189ed 100644 --- a/lib/diff.tcl +++ b/lib/diff.tcl @@ -300,9 +300,9 @@ proc start_show_diff {cont_info {add_opts {}}} { || [string match {160000 *} [lindex $s 3]]} { set is_submodule_diff 1 if {$w eq $ui_index} { - set cmd {submodule summary --cached -- $current_diff_path} + set cmd [list submodule summary --cached -- $path] } else { - set cmd {submodule summary --files -- $current_diff_path} + set cmd [list submodule summary --files -- $path] } }