From: Florian Forster <octo@collectd.org>
Date: Thu, 18 Jun 2015 15:46:03 +0000 (+0200)
Subject: snmp plugin: Fix "Assigned value is garbage or undefined" warning.
X-Git-Tag: collectd-5.5.1~68^2~37
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=0c62bc40d4058f95dc6f3eff9da32befe4925751;p=collectd.git

snmp plugin: Fix "Assigned value is garbage or undefined" warning.
---

diff --git a/src/snmp.c b/src/snmp.c
index 4dd1d10c..858d44c5 100644
--- a/src/snmp.c
+++ b/src/snmp.c
@@ -1053,16 +1053,17 @@ static int csnmp_dispatch_table (host_definition_t *host, data_definition_t *dat
     return (-1);
   }
   assert (ds->ds_num == data->values_len);
+  assert (data->values_len > 0);
 
   instance_list_ptr = instance_list;
 
-  value_table_ptr = malloc (sizeof (*value_table_ptr) * data->values_len);
+  value_table_ptr = calloc ((size_t) data->values_len, sizeof (*value_table_ptr));
   if (value_table_ptr == NULL)
     return (-1);
   for (i = 0; i < data->values_len; i++)
     value_table_ptr[i] = value_table[i];
 
-  vl.values_len = ds->ds_num;
+  vl.values_len = data->values_len;
   vl.values = malloc (sizeof (*vl.values) * vl.values_len);
   if (vl.values == NULL)
   {