From: Jeff King Date: Sun, 20 Mar 2011 09:19:01 +0000 (-0400) Subject: checkout: tweak detached-orphan warning format X-Git-Tag: v1.7.5-rc0~19^2 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=0be240cc65c2230d0c9732dbe0e2490a9331ea32;p=git.git checkout: tweak detached-orphan warning format When orphaning a commit on a detached HEAD, the warning currently looks like: Warning: you are leaving 3 commits behind, not connected to any of your branches: - commit subject 1 - commit subject 2 - commit subject 3 If you want to keep them by creating a new branch, this may be a good time to do so with: git branch new_branch_name 933a615ab0bc566dcfd8c01ec8af159f770d3fe5 Instead of using the "-" list, let's provide a more traditional oneline format, with the abbreviated sha1 before each subject. Users are accustomed to seeing commits in this format, and having the sha1 of each commit can be useful if you want to cherry-pick instead of creating a new branch. The new format looks like: Warning: you are leaving 3 commits behind, not connected to any of your branches: 933a615 commit subject 1 824fcde commit subject 2 fa49b1a commit subject 3 Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/builtin/checkout.c b/builtin/checkout.c index f88d2c84a..686d0ffd3 100644 --- a/builtin/checkout.c +++ b/builtin/checkout.c @@ -619,7 +619,10 @@ static void describe_one_orphan(struct strbuf *sb, struct commit *commit) struct pretty_print_context ctx = { 0 }; parse_commit(commit); - strbuf_addstr(sb, " - "); + strbuf_addstr(sb, " "); + strbuf_addstr(sb, + find_unique_abbrev(commit->object.sha1, DEFAULT_ABBREV)); + strbuf_addch(sb, ' '); pretty_print_commit(CMIT_FMT_ONELINE, commit, sb, &ctx); strbuf_addch(sb, '\n'); }