From: Jonas Fonseca <fonseca@diku.dk>
Date: Wed, 9 Jun 2010 03:10:08 +0000 (-0400)
Subject: Free blame view data when reloading view
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=0bc05be08ffc3b7eed6544c7d637a4da67e16917;p=tig.git

Free blame view data when reloading view
---

diff --git a/NEWS b/NEWS
index 190e5dc..f46ee70 100644
--- a/NEWS
+++ b/NEWS
@@ -16,6 +16,7 @@ Incompatibilities:
 
 Improvements:
 
+ - Plug several memory leaks.
  - Command line arguments are split into diff, revision, and file
    arguments and made available as %(diff-args), %(rev-args), and
    %(file-args). Diff view will limit diffs using %(file-args).
diff --git a/tig.c b/tig.c
index c963977..810e5e7 100644
--- a/tig.c
+++ b/tig.c
@@ -4911,6 +4911,7 @@ static bool
 blame_open(struct view *view)
 {
 	char path[SIZEOF_STR];
+	size_t i;
 
 	if (!view->prev && *opt_prefix) {
 		string_copy(path, opt_file);
@@ -4928,6 +4929,24 @@ blame_open(struct view *view)
 			return FALSE;
 	}
 
+	/* First pass: remove multiple references to the same commit. */
+	for (i = 0; i < view->lines; i++) {
+		struct blame *blame = view->line[i].data;
+
+		if (blame->commit && blame->commit->id[0])
+			blame->commit->id[0] = 0;
+		else
+			blame->commit = NULL;
+	}
+
+	/* Second pass: free existing references. */
+	for (i = 0; i < view->lines; i++) {
+		struct blame *blame = view->line[i].data;
+
+		if (blame->commit)
+			free(blame->commit);
+	}
+
 	setup_update(view, opt_file);
 	string_format(view->ref, "%s ...", opt_file);