From: Elijah Newren Date: Fri, 12 Aug 2011 05:19:54 +0000 (-0600) Subject: merge-recursive: Avoid working directory changes during recursive case X-Git-Tag: v1.7.7-rc1~28^2~36 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=0b30e8125130a78bc7c0e13e7f45ba105bd206b8;p=git.git merge-recursive: Avoid working directory changes during recursive case make_room_for_directories_of_df_conflicts() is about making sure necessary working directory changes can succeed. When o->call_depth > 0 (i.e. the recursive case), we do not want to make any working directory changes so this function should be skipped. Note that make_room_for_directories_of_df_conflicts() is broken as has been pointed out by Junio; it should NOT be unlinking files. What it should do is keep track of files that could be unlinked if a directory later needs to be written in their place. However, that work also is only relevant in the non-recursive case, so this change is helpful either way. Signed-off-by: Elijah Newren Signed-off-by: Junio C Hamano --- diff --git a/merge-recursive.c b/merge-recursive.c index f172df169..e6a6a81ec 100644 --- a/merge-recursive.c +++ b/merge-recursive.c @@ -353,6 +353,13 @@ static void make_room_for_directories_of_df_conflicts(struct merge_options *o, int last_len = 0; int i; + /* + * If we're merging merge-bases, we don't want to bother with + * any working directory changes. + */ + if (o->call_depth) + return; + for (i = 0; i < entries->nr; i++) { const char *path = entries->items[i].string; int len = strlen(path);