From: Shawn Pearce Date: Tue, 11 Jul 2006 00:27:54 +0000 (-0400) Subject: Allow user.name and user.email to drive reflog entry. X-Git-Tag: v1.4.2-rc1~44 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=0b0fe4a65d24d7c17d72706e5cd179ecc7134721;p=git.git Allow user.name and user.email to drive reflog entry. Apparently calling setup_ident() after git_config causes the user.name and user.email values read from the config file to be replaced with the data obtained from the host. This means that users who have setup their email address in user.email will instead be writing reflog entries with their hostname. Moving setup_ident() to before git_config in update-ref resolves this ordering problem. Signed-off-by: Shawn O. Pearce Signed-off-by: Junio C Hamano --- diff --git a/builtin-update-ref.c b/builtin-update-ref.c index 00333c7e7..83094abe0 100644 --- a/builtin-update-ref.c +++ b/builtin-update-ref.c @@ -12,6 +12,7 @@ int cmd_update_ref(int argc, const char **argv, char **envp) unsigned char sha1[20], oldsha1[20]; int i; + setup_ident(); setup_git_directory(); git_config(git_default_config); diff --git a/refs.c b/refs.c index 2d9c1dc5d..56db39445 100644 --- a/refs.c +++ b/refs.c @@ -379,7 +379,6 @@ static int log_ref_write(struct ref_lock *lock, lock->log_file, strerror(errno)); } - setup_ident(); committer = git_committer_info(1); if (msg) { maxlen = strlen(committer) + strlen(msg) + 2*40 + 5;