From: Miklos Vajna <vmiklos@frugalware.org>
Date: Thu, 22 May 2008 23:26:09 +0000 (+0200)
Subject: CodingGuidelines: Add a note to avoid assignments inside if()
X-Git-Tag: v1.5.6-rc0~18
X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=0b0b8cd7c2c3df72fc3959805b035e55e1bb1270;p=git.git

CodingGuidelines: Add a note to avoid assignments inside if()

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index 994eb9159..d2a0a76e6 100644
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines
@@ -89,6 +89,8 @@ For C programs:
    of "else if" statements, it can make sense to add braces to
    single line blocks.
 
+ - We try to avoid assignments inside if().
+
  - Try to make your code understandable.  You may put comments
    in, but comments invariably tend to stale out when the code
    they were describing changes.  Often splitting a function